[webkit-reviews] review requested: [Bug 105735] Move ENABLE macros for WebCore out from Platform.h and add all the macros from the FeatureFlags wiki : [Attachment 180699] 1st take

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.gombos at webkit.org> has asked  for review:
Bug 105735: Move ENABLE macros for WebCore out from Platform.h and add all the
macros from the FeatureFlags wiki
https://bugs.webkit.org/show_bug.cgi?id=105735

Attachment 180699: 1st take
https://bugs.webkit.org/attachment.cgi?id=180699&action=review

------- Additional Comments from Laszlo Gombos <laszlo.gombos at webkit.org>
Note that this is only a first step of some larger re-factoring.

I set the macros with no defaults in Platform.h - to "TBD". The value for TBD
is not important at the moment as most build systems already define these
macros, so these new rules in FeatureDefines.h will not execute. I hope to get
rid of all these TBDs in a follow-up patch (I think most of these features can
be just enabled by default and let the port specific build system disable them
if they need to).

To get the list of all ENABLE macros one can just now run - grep -o
"ENABLE_\(\w\+\)" wtf/FeatureDefines.h | sort | uniq.

To get the list of features enabled by default for a PLATFORM(XXX) assuming
that the build system does not define them: gcc -E -dM -I. -DWTF_PLATFORM_XXX
"wtf/Platform.h" | grep "ENABLE_\w\+ 1" | cut -d' ' -f2 | sort