[webkit-reviews] review denied: [Bug 105727] Web Inspector: Support inspector file system access with isolated file system through InspectorFrontendHost. : [Attachment 180676] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 105727: Web Inspector: Support inspector file system access with isolated
file system through InspectorFrontendHost.
https://bugs.webkit.org/show_bug.cgi?id=105727

Attachment 180676: Patch
https://bugs.webkit.org/attachment.cgi?id=180676&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180676&action=review


> Source/WebCore/inspector/InspectorFrontendClient.h:75
> +    virtual bool canAccessFileSystem() = 0;

supportsFilesystems()

> Source/WebCore/inspector/InspectorFrontendClient.h:76
> +    virtual void requestFileSystemPermissions() = 0;

requestFilesystems()

> Source/WebCore/inspector/InspectorFrontendClient.h:77
> +    virtual void selectFolderAndGrantFileSystemPermission() = 0;

addFilesystem()

> Source/WebCore/inspector/InspectorFrontendClient.h:78
> +    virtual void revokeFileSystemPermission(const String& fileSystemPath) =
0;

removeFilesystem()

> Source/WebCore/inspector/front-end/FileSystemMapping.js:40
> +    fileSystemPathes: function() { },

Paths

> Source/WebCore/inspector/front-end/FileSystemMapping.js:46
> +    fileSystemPathForURI: function(uri) { },

fileSystemForURI

> Source/WebCore/inspector/front-end/FileSystemMapping.js:52
> +    filePathForURI: function(uri) { },

pathForURI

> Source/WebCore/inspector/front-end/FileSystemMapping.js:59
> +    uriForPath: function(fileSystemPath, filePath) { },

Should you introduce a FileDescriptor class?

> Source/WebCore/inspector/front-end/FileSystemMapping.js:65
> +    uriPrefixForPath: function(path) { }

Why do you need this?