[webkit-reviews] review denied: [Bug 103945] Web Inspector: Add context menu item to re-run an audit from results : [Attachment 180484] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has denied Vivek Galatage
<vivek.vg at samsung.com>'s request for review:
Bug 103945: Web Inspector: Add context menu item to re-run an audit from
results
https://bugs.webkit.org/show_bug.cgi?id=103945

Attachment 180484: Patch
https://bugs.webkit.org/attachment.cgi?id=180484&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180484&action=review


>> Source/WebCore/inspector/front-end/AuditLauncherView.js:172
>> +		if (!runImmediately)
> 
> so if we pass false as runImmediately, we will use UI as an override?
> I think the code would be a bit more readableif this function is split in two
-- one that gets categories & runImmediately flag from UI and another that
starts audit with given categories and runImmediately flag.

As discussed on IRC, this should act as an API method of the audit runner
Model, and the arguments should come from the UI (provided by a View method).