[webkit-reviews] review granted: [Bug 105682] Make CustomProtocolManager a MessageReceiver to remove more special casing : [Attachment 180612] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 105682: Make CustomProtocolManager a MessageReceiver to remove more special
casing
https://bugs.webkit.org/show_bug.cgi?id=105682

Attachment 180612: Patch
https://bugs.webkit.org/attachment.cgi?id=180612&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180612&action=review


> Source/WebKit2/ChangeLog:22
> +	   Call connectionEstablished on the CustomProtocolManager to make
start working as a NSURLProtocol handler.

Missing word!

> Source/WebKit2/ChangeLog:35
> +	   (WebKit):

WebKit?

> Source/WebKit2/ChangeLog:42
> +	   (WebKit):

WebKit??

> Source/WebKit2/ChangeLog:46
> +	   Make CustomProtocolManager a MessageReceiver and split
initialization and
> +	   from the time when it can start acting as protocol handler as these
happen at

initialization and what?

> Source/WebKit2/ChangeLog:61
> +	   Call connectionEstablished on the CustomProtocolManager to make
start working as a NSURLProtocol handler.

$ make start
make: *** No rule to make target `start'.  Stop.