[webkit-reviews] review denied: [Bug 105602] [EFL][WebGL] Implement EGL support with GLX : [Attachment 180602] rebasedpatch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Kalyan
<kalyan.kondapally at intel.com>'s request for review:
Bug 105602: [EFL][WebGL] Implement EGL support with GLX
https://bugs.webkit.org/show_bug.cgi?id=105602

Attachment 180602: rebasedpatch
https://bugs.webkit.org/attachment.cgi?id=180602&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180602&action=review


The dependency between EGL & X11 needs to be more explicit and encapsulated.

> Source/WebCore/ChangeLog:24
> +	   EGL implementation for Context Management.

Put comment after filenames

> Source/WebCore/ChangeLog:44
> +	   EGL implementation for Offscreen Surface.

Ditto

> Source/WebCore/ChangeLog:57
> +	   X integration.

Ditto

> Source/WebCore/platform/graphics/surfaces/egl/EGLSurface.h:37
> +class EGLTransportSurface : public X11OffScreenWindow {

This should be an EGLX11TransportSurface.
EGL doesn't always support X11.

> Source/WebCore/platform/graphics/surfaces/glx/EGLXWindowResources.h:37
> +class SharedEGLResources : public SharedX11Resources {

What is the benefit of tying EGL resources to X11 resources? Can we somehow
separate them a bit better?