[webkit-reviews] review granted: [Bug 105058] Implement WebIDL-style string constants in WebAudio : [Attachment 180559] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 105058: Implement WebIDL-style string constants in WebAudio
https://bugs.webkit.org/show_bug.cgi?id=105058

Attachment 180559: Patch
https://bugs.webkit.org/attachment.cgi?id=180559&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180559&action=review


LGTM. Thanks for the patch!

> Source/WebCore/Modules/webaudio/OscillatorNode.cpp:113
> +    else if (type == "triangle")
> +	   setType(TRIANGLE);

Let's add:

  else
    ASSERT_NOT_REACHED();