[webkit-reviews] review granted: [Bug 105646] ASSERT in WebResourceLoadScheduler::scheduleLoad with a crashed NetworkProcess with release build symptoms. : [Attachment 180548] Patch v1

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 105646: ASSERT in WebResourceLoadScheduler::scheduleLoad with a crashed
NetworkProcess with release build symptoms.
https://bugs.webkit.org/show_bug.cgi?id=105646

Attachment 180548: Patch v1
https://bugs.webkit.org/attachment.cgi?id=180548&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180548&action=review


> Source/WebKit2/ChangeLog:10
> +	   Since these loaders will never succeed in loading we should schedule
them to fail on a timer.

We could also retry the load, but that's a lot of complexity for a case that
should never ever happen.

> Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.h:70
> +    HashSet<RefPtr<WebCore::ResourceLoader> > m_failedResourceLoaders;

I'd appreciate a more descriptive name, this set is not used for regular failed
loads (e.g. unreachable host).