[webkit-reviews] review denied: [Bug 105592] Perform cleanup in WebProcess if the NetworkProcess crashes : [Attachment 180532] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 21 10:17:56 PST 2012


Alexey Proskuryakov <ap at webkit.org> has denied Brady Eidson
<beidson at apple.com>'s request for review:
Bug 105592: Perform cleanup in WebProcess if the NetworkProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=105592

Attachment 180532: Patch v1
https://bugs.webkit.org/attachment.cgi?id=180532&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Discussed this in person.

1. It should be a real load failure, not cancellation.
2. cancel() should call into NetworkProcess (to actually cancel in normal
case), which we don't want to do here.


More information about the webkit-reviews mailing list