[webkit-reviews] review granted: [Bug 105632] [EFL][WK2] Never create WebCore scrollbars for EFL/WK2 : [Attachment 180507] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 105632: [EFL][WK2] Never create WebCore scrollbars for EFL/WK2
https://bugs.webkit.org/show_bug.cgi?id=105632

Attachment 180507: Patch
https://bugs.webkit.org/attachment.cgi?id=180507&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180507&action=review


> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1238
> +    m_frame->coreFrame()->createView(webPage->size(), backgroundColor, /*
transparent */ false, IntSize(), currentFixedVisibleContentRect,
shouldUseFixedLayout, ScrollbarAlwaysOff, true, ScrollbarAlwaysOff, true);

would be nice to have true /*comment*/ here

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1246
> +   
m_frame->coreFrame()->view()->setTransparent(!webPage->drawsBackground());

can not you pass this as one of the parameter of createView?