[webkit-reviews] review requested: [Bug 105548] [CSS Grid Layout] Add the plumbing to parse -webkit-grid-{column, row}-span : [Attachment 180500] column-row-span.diff

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 105548: [CSS Grid Layout] Add the plumbing to parse
-webkit-grid-{column,row}-span
https://bugs.webkit.org/show_bug.cgi?id=105548

Attachment 180500: column-row-span.diff
https://bugs.webkit.org/attachment.cgi?id=180500&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
As done in previous features, this only adds the parsing bits, no effects on
layout yet.

The two things I consider are probably up for debate:

- I use GridPosition to store the span, it might be better to create a new type
(GridSpan?)
- I actually store the span in the item data. Perhaps it would be better to
store a second GridPosition (m_gridColumnEnd, m_gridRowEnd?), and figure out
the span doing end-start.