[webkit-reviews] review granted: [Bug 105564] [GTK] Remove plugin process configuration option : [Attachment 180387] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 105564: [GTK] Remove plugin process configuration option
https://bugs.webkit.org/show_bug.cgi?id=105564

Attachment 180387: Patch
https://bugs.webkit.org/attachment.cgi?id=180387&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=180387&action=review


This will automatically fix bug #89451. Thanks!

> Source/WebKit2/ChangeLog:13
> +

I think in-process plugin process is indeed incompatible in GTK+, because
WebKit2 depends on GTK+ 3 and plugin process requires GTK+ 2 to work. When
built in-process it would use GTK+ 3 and some plugins like flash won't work.
You might want to mention it in the ChangeLog to make it clear we are not
removing it just for the sake of reducing the configuration options.