[webkit-reviews] review denied: [Bug 67166] Update CSS3 gradient support to the latest spec version : [Attachment 180446] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has denied Tab Atkins <tabatkins at google.com>'s
request for review:
Bug 67166: Update CSS3 gradient support to the latest spec version
https://bugs.webkit.org/show_bug.cgi?id=67166

Attachment 180446: Patch
https://bugs.webkit.org/attachment.cgi?id=180446&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=180446&action=review


Patches up for review should always include tests (i.e. if you're setting the
r? flag). If you just want someone to take a look, then it seems people label
their uploads "wip" or something like that.

After a quick glance this looks fine to me. You should go ahead and make the
tests.

> Source/WebCore/ChangeLog:11
> +	   * css/CSSGradientValue.cpp:
> +	   (WebCore::CSSGradientValue::computeEndPoint):

I've been schooled to always provide comments here if possible. e.g. "Renaming
parameters to make much more sense"