[webkit-reviews] review requested: [Bug 105480] Implement element type selectors for the WebVTT ::cue pseudo class : [Attachment 180441] Proposed fix 0.1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 20 16:38:47 PST 2012
Dima Gorbik <dgorbik at apple.com> has asked for review:
Bug 105480: Implement element type selectors for the WebVTT ::cue pseudo class
https://bugs.webkit.org/show_bug.cgi?id=105480
Attachment 180441: Proposed fix 0.1
https://bugs.webkit.org/attachment.cgi?id=180441&action=review
------- Additional Comments from Dima Gorbik <dgorbik at apple.com>
I suggest moving tag comparison to the overloaded "==" operator of a
QualifiedName. That would simplify SelectorChecker::tagMatches quite a bit.
All general tag names like i, b, ruby and rt are being already handled. This
patch adds the support for rare cases with "c" and "v" tags.
I will add layout tests after the previous patch is being reviewed
(https://bugs.webkit.org/show_bug.cgi?id=105473) because they will be based on
the existing layout tests from that patch.
More information about the webkit-reviews
mailing list