[webkit-reviews] review denied: [Bug 105579] [flexbox] Fix handling of very large flex grow/shrink values : [Attachment 180414] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 105579: [flexbox] Fix handling of very large flex grow/shrink values
https://bugs.webkit.org/show_bug.cgi?id=105579

Attachment 180414: Patch
https://bugs.webkit.org/attachment.cgi?id=180414&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180414&action=review


> Source/WebCore/ChangeLog:11
> +	   No new tests (OOPS!).

Need to remove the OOPS. Maybe mention that this is covered by
css3/flexbox/flex-algorithm.html.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:988
> +	       double extraSpace;

I think you need to initialize this because it might not be set below.