[webkit-reviews] review granted: [Bug 105370] REGRESSION(r133820?): SimplifyMarkupTest API test asserts : [Attachment 180400] Improved the change log entry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 20 14:28:02 PST 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 105370: REGRESSION(r133820?): SimplifyMarkupTest API test asserts
https://bugs.webkit.org/show_bug.cgi?id=105370

Attachment 180400: Improved the change log entry
https://bugs.webkit.org/attachment.cgi?id=180400&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=180400&action=review


> Source/WebCore/editing/SimplifyMarkupCommand.cpp:114
> +    if (pastLastNodeToRemove == startNodeIndex + 1)
> +	   return 0;

These return values are so mysterious.


More information about the webkit-reviews mailing list