[webkit-reviews] review denied: [Bug 31397] Inline Containing Only Collapsed Whitespace Not Getting a Linebox : [Attachment 180382] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 31397: Inline Containing Only Collapsed Whitespace Not Getting a Linebox
https://bugs.webkit.org/show_bug.cgi?id=31397

Attachment 180382: Patch
https://bugs.webkit.org/attachment.cgi?id=180382&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=180382&action=review


MOstly looks ok. One line stands out.

> Source/WebCore/dom/Position.cpp:852
> +		   || (o->isRenderInline() &&
toRenderInline(o)->linesBoundingBox().height()))

I don't really understand this addition. It seems like you only want to do this
if the inline is empty. This code already recurs into the inline's children, so
isn't this a case where the inline needs to be empty also, or otherwise you're
O(n^2)?