[webkit-reviews] review denied: [Bug 77864] [Qt] Initial implementation of accessibility support : [Attachment 180345] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Frederik Gladhorn
<gladhorn at kde.org>'s request for review:
Bug 77864: [Qt] Initial implementation of accessibility support
https://bugs.webkit.org/show_bug.cgi?id=77864

Attachment 180345: Patch
https://bugs.webkit.org/attachment.cgi?id=180345&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180345&action=review


> Source/WTF/WTF.pri:42
> +haveQt(5): contains(QT_CONFIG,accessibility): DEFINES +=
HAVE_ACCESSIBILITY=1

This should probably go into features.pri.

> Source/WebCore/accessibility/qt/AccessibilityObjectQt.cpp:40
> +void AccessibilityObject::setWrapper(AccessibilityObjectWrapper *wrapper)

* placement

> Source/WebCore/accessibility/qt/AccessibilityObjectWrapperQt.cpp:126
> +		       QScopedPointer<QAccessibleInterface>
webView(QAccessible::queryAccessibleInterface(pageClient->ownerWidget()));

How do the other ports handle this? Is there a simpler or common way?

> Source/WebCore/accessibility/qt/AccessibilityObjectWrapperQt.h:28
> +class QWebFrame;

That doesn't seem to be needed

> Source/WebKit/qt/WidgetApi/qwebviewaccessible.cpp:34
> +    if (!WebCore::AXObjectCache::accessibilityEnabled())

This class (qwebviewaccessible) needs to move from QtWebKitWidgets into
QtWebKit. Try compiling with make && make to see when this is needed (instead
of build-webkit)

(This is a flaw in our current build process)