[webkit-reviews] review granted: [Bug 105516] PDFPlugin: Cannot drop files/URLs on PDFPlugin : [Attachment 180306] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 105516: PDFPlugin: Cannot drop files/URLs on PDFPlugin
https://bugs.webkit.org/show_bug.cgi?id=105516

Attachment 180306: patch
https://bugs.webkit.org/attachment.cgi?id=180306&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180306&action=review


> we can guarantee it doesn't have anything else handling drags.

Not even text fields in PDF forms?

> Source/WebCore/page/DragController.cpp:413
> +    if (doc->isPluginDocument()) {

There is a null check for doc below. Either it's not needed, or this new code
can crash.

> Source/WebCore/page/DragController.cpp:415
> +	   const PluginViewBase* pluginView = widget &&
widget->isPluginViewBase() ? static_cast<const PluginViewBase*>(widget) : 0;

I like to have braces around ternary conditions FWIW - it makes them look more
like if () conditions.