[webkit-reviews] review denied: [Bug 105264] Percentage min/max width replaced element may incorrectly rendered : [Attachment 180256] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied KyungTae Kim <ktf.kim at samsung.com>'s
request for review:
Bug 105264: Percentage min/max width replaced element may incorrectly rendered
https://bugs.webkit.org/show_bug.cgi?id=105264

Attachment 180256: Patch
https://bugs.webkit.org/attachment.cgi?id=180256&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180256&action=review


Please use an enum. See
http://www.webkit.org/coding/coding-style.html#names-enum-to-bool

> Source/WebCore/rendering/RenderReplaced.cpp:452
>      // FIXME: We shouldn't be calling a logical width computing function in
preferred
>      // logical widths computation as the layout information is probably
invalid.

I think this fixes this FIXME. You can remove this comment.

> Source/WebCore/rendering/RenderReplaced.h:35
> +    virtual LayoutUnit computeReplacedLogicalWidth(bool isComputePreferred =
false) const;

OVERRIDE

> Source/WebCore/rendering/RenderVideo.h:73
> +    virtual LayoutUnit computeReplacedLogicalWidth(bool isComputePreferred =
false) const;

OVERRIDE