[webkit-reviews] review granted: [Bug 105540] CodeGen: Make [Reflect] use fastGetAttribute and fastHasAttribute : [Attachment 180349] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 20 09:25:33 PST 2012


Andreas Kling <akling at apple.com> has granted Erik Arvidsson
<arv at chromium.org>'s request for review:
Bug 105540: CodeGen: Make [Reflect] use fastGetAttribute and fastHasAttribute
https://bugs.webkit.org/show_bug.cgi?id=105540

Attachment 180349: Patch
https://bugs.webkit.org/attachment.cgi?id=180349&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
r=me, great idea!

Maybe we could also use getIdAttribute()/getNameAttribute() for id/name to
avoid iterating over the attribute list in case the attribute isn't present.


More information about the webkit-reviews mailing list