[webkit-reviews] review denied: [Bug 105438] Web Inspector: Make use of the new InspectorState::remove() in inspector agents : [Attachment 180336] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 105438: Web Inspector: Make use of the new InspectorState::remove() in
inspector agents
https://bugs.webkit.org/show_bug.cgi?id=105438

Attachment 180336: Patch
https://bugs.webkit.org/attachment.cgi?id=180336&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
I'd suggest the following refactoring that would make things even better:
structure state so that instead of holding all agents' states in a single flat
m_properties map, it would have an object property per agent. The resetting the
state of a particular agent would be as simple as resetting its state object
(or replacing it with new blank object). Such refactoring would require
InspectorController to shard state object and pass individual InspectorState
into each of the agents.