[webkit-reviews] review granted: [Bug 99984] [SVG] SVGPreserveAspectRatio::transformRect is done incorrectly in 'slice' mode : [Attachment 177747] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Branimir Lambov
<blambov at google.com>'s request for review:
Bug 99984: [SVG] SVGPreserveAspectRatio::transformRect is done incorrectly in
'slice' mode
https://bugs.webkit.org/show_bug.cgi?id=99984

Attachment 177747: Patch
https://bugs.webkit.org/attachment.cgi?id=177747&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
I agree with Dirk that the ChangeLog could be more descriptive, you're telling
us what was done but not why. Ideally you'd reference the SVG spec formulas
here, or some other source proving our implementation is wrong.
That would have sped-up the review process :-) Anyhow, please be careful with
not breaking mac EWS, it's red. I'll r+ this, but Dirk or others can feel free
to r- it again, if the ChangeLog should be updated for instance.