[webkit-reviews] review granted: [Bug 105437] Incorrect color space conversion for FEImage : [Attachment 180224] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Florin Malita
<fmalita at chromium.org>'s request for review:
Bug 105437: Incorrect color space conversion for FEImage
https://bugs.webkit.org/show_bug.cgi?id=105437

Attachment 180224: Patch
https://bugs.webkit.org/attachment.cgi?id=180224&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180224&action=review


r=me. But agree with schenney.

>> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:460
>>  #endif
> 
> Dammit, this was lost the first time through. Why oh why?
> 
> You can avoid the goto by putting "else {" inside the if/end and then putting
"}" inside the if/end below (there the goto target is now). We use this pattern
elsewhere in the code and it is nicer.

yes, please use else { or #else. Better the first one.