[webkit-reviews] review granted: [Bug 104845] window.crypto.getRandomValues should return the input ArrayBufferView : [Attachment 180267] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Ryan Sleevi
<rsleevi at chromium.org>'s request for review:
Bug 104845: window.crypto.getRandomValues should return the input
ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=104845

Attachment 180267: Patch
https://bugs.webkit.org/attachment.cgi?id=180267&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180267&action=review


Actually I'm not so happy with the approach, because you're trying to solve
ArrayBufferView's problem by adding some hacks to V8Crypto. That being said, I
cannot come up with a better idea to solve ArrayBufferView's problem, so I'm
not objecting to landing the patch for now.

> Source/WebCore/bindings/js/JSCryptoCustom.cpp:51
> +    if (UNLIKELY(ec)) {

Remove UNLIKELY(). It would be useless.

> Source/WebCore/bindings/v8/custom/V8CryptoCustom.cpp:54
> +    if (UNLIKELY(ec))

Remove UNLIKELY(). It would be useless.