[webkit-reviews] review canceled: [Bug 100754] Faster sorting of numeric arrays : [Attachment 180006] Patch and tests

[bugzilla-daemon at webkit.org]

Cosmin Truta <ctruta at gmail.com> has canceled Cosmin Truta <ctruta at gmail.com>'s
request for review:
Bug 100754: Faster sorting of numeric arrays
https://bugs.webkit.org/show_bug.cgi?id=100754

Attachment 180006: Patch and tests
https://bugs.webkit.org/attachment.cgi?id=180006&action=review

------- Additional Comments from Cosmin Truta <ctruta at gmail.com>
Inclusion of bytecode/UnlinkedCodeBlock.h indirectly included
parser/ParserTokens.h, and the latter contains all-caps enum symbols that
clashed with macros (e.g. FUNCTION, COMMA, SEMICOLON) defined elsewhere. This
broke the build on Mac and Qt.
I resolved this breakage by moving ComparatorKind into a separate file, which
allowed the include dependencies to be alleviated.
Now there shouldn't be any WebKit2 breakages either. I undid the WebKit2
changes that had been submitted with the previous patch.