[webkit-reviews] review granted: [Bug 104845] window.crypto.getRandomValues should return the input ArrayBufferView : [Attachment 180257] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted  review:
Bug 104845: window.crypto.getRandomValues should return the input
ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=104845

Attachment 180257: Patch
https://bugs.webkit.org/attachment.cgi?id=180257&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=180257&action=review


Despite the introduction of custom code, this looks much better and safer to
me. r=me, but needs a couple of minor updates before committing.

> Source/WebCore/bindings/js/JSCryptoCustom.cpp:14
> + *	  * Neither the name of Google Inc. nor the names of its

Wrong form of BSD license. Please use the two-clause license in
Source/WebKit/LICENSE.

> Source/WebCore/bindings/v8/custom/V8CryptoCustom.cpp:14
> + *	  * Neither the name of Google Inc. nor the names of its

Same license issue.

> LayoutTests/ChangeLog:9
> +	   * security/crypto-random-values-types.html:

Please regenerate ChangeLog so that change to js-test-pre.js is included.

> LayoutTests/security/crypto-random-values-types.html:45
> +checkNonIntegerTypes();

Would be nice to test DataView too and ensure that it throws an exception.