[webkit-reviews] review requested: [Bug 105467] [WK2 NetworkProcess] Client doesn't receive SSL certificates : [Attachment 180249] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 19 16:51:04 PST 2012


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 105467: [WK2 NetworkProcess] Client doesn't receive SSL certificates
https://bugs.webkit.org/show_bug.cgi?id=105467

Attachment 180249: updated patch
https://bugs.webkit.org/attachment.cgi?id=180249&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Discussed this with Brady in person.

I think that the right design is for ResourceRequest and ResourceResponse
serializers to only preserve essential lightweight data. Parts that we rarely
need can be sent over IPC as separate arguments. Another example of this is how
we shouldn't serialize form data with each ResourceRequest.

Another consideration is that we should really think about only passing
certificate chain data on demand, not with ResourceResponse.

As a result of this discussion, I renamed didReceiveResponse to
didReceiveResponseWithCertificateInfo, so that it doesn't look confusingly
similar to other didReceiveResponse functions.


More information about the webkit-reviews mailing list