[webkit-reviews] review granted: [Bug 105447] Add a function to set the origin hash table : [Attachment 180210] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 19 16:15:54 PST 2012


Brian Weinstein <bweinstein at apple.com> has granted Jon Lee <jonlee at apple.com>'s
request for review:
Bug 105447: Add a function to set the origin hash table
https://bugs.webkit.org/show_bug.cgi?id=105447

Attachment 180210: Patch
https://bugs.webkit.org/attachment.cgi?id=180210&action=review

------- Additional Comments from Brian Weinstein <bweinstein at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=180210&action=review


> Source/WebKit2/ChangeLog:10
> +	   keyed by main frame origin, into the WebContext. That, in turn,
notifies all existing web

sets... into the WebContext reads a bit strangely, but not sure what would be
better.

> Source/WebKit2/WebProcess/WebProcess.cpp:839
> +	   m_plugInAutoStartOrigins.add(hashes[i]);

Is it worth calling didAddPlugInAutoStartOrigin(hashes[i]) here? In case we
need to add more to that function.


More information about the webkit-reviews mailing list