[webkit-reviews] review denied: [Bug 105467] [WK2 NetworkProcess] Client doesn't receive SSL certificates : [Attachment 180233] proposed fix

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 105467: [WK2 NetworkProcess] Client doesn't receive SSL certificates
https://bugs.webkit.org/show_bug.cgi?id=105467

Attachment 180233: proposed fix
https://bugs.webkit.org/attachment.cgi?id=180233&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=180233&action=review


> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:155
> -    send(Messages::WebResourceLoader::DidReceiveResponse(response));
> +    send(Messages::WebResourceLoader::DidReceiveResponse(response,
PlatformCertificateInfo(response)));

I would much rather see us keep the cert chain encapsulated by the response,
and just encode it in the ResourceResponse encoder when it exists.

> Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:84
> -void WebResourceLoader::didReceiveResponse(const WebCore::ResourceResponse&
response)
> +void WebResourceLoader::didReceiveResponse(const ResourceResponse& response,
const PlatformCertificateInfo& certificateInfo)
>  {
>      LOG(Network, "(WebProcess) WebResourceLoader::didReceiveResponse for
'%s'. Status %d.", m_coreLoader->url().string().utf8().data(),
response.httpStatusCode());
> -    m_coreLoader->didReceiveResponse(response);
> +    ResourceResponse responseCopy(response);
> +    responseCopy.setCertificateChain(certificateInfo.certificateChain());
> +    m_coreLoader->didReceiveResponse(responseCopy);

Then none of this would be required.