[webkit-reviews] review granted: [Bug 105454] [WK2 NetworkProcess] Cannot log into gmail/facebook with private browsing enabled : [Attachment 180209] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 19 12:38:32 PST 2012


Brady Eidson <beidson at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 105454: [WK2 NetworkProcess] Cannot log into gmail/facebook with private
browsing enabled
https://bugs.webkit.org/show_bug.cgi?id=105454

Attachment 180209: proposed fix
https://bugs.webkit.org/attachment.cgi?id=180209&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=180209&action=review


> Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:565
> +    // Client call may not preserve the session, especially it the request
is sent over IPC.
> +    request.setStorageSession(d->m_storageSession.get());

s/especially it/especially if/

> Source/WebCore/platform/network/mac/ResourceHandleMac.mm:478
> +    // Client call may not preserve the session, especially it the request
is sent over IPC.
> +    request.setStorageSession(d->m_storageSession.get());

s/especially it/especially if/


More information about the webkit-reviews mailing list