[webkit-reviews] review denied: [Bug 105330] REGRESSION(r137607): resource load client callbacks are not called for the main resource when loading HTML string : [Attachment 180188] japhet's attempt

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 105330: REGRESSION(r137607): resource load client callbacks are not called
for the main resource when loading HTML string
https://bugs.webkit.org/show_bug.cgi?id=105330

Attachment 180188: japhet's attempt
https://bugs.webkit.org/attachment.cgi?id=180188&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=180188&action=review


> Source/WebCore/loader/MainResourceLoader.cpp:697
>  unsigned long MainResourceLoader::identifier() const
>  {
> +    if (m_identifier)
> +	   return m_identifier;
>      if (ResourceLoader* resourceLoader = loader())
>	   return resourceLoader->identifier();

This breaks the "setIdentifier" API on ResourceLoader that WebKit2 relies on.