[webkit-reviews] review denied: [Bug 105264] Percentage min/max width replaced element may incorrectly rendered : [Attachment 180107] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied KyungTae Kim <ktf.kim at samsung.com>'s
request for review:
Bug 105264: Percentage min/max width replaced element may incorrectly rendered
https://bugs.webkit.org/show_bug.cgi?id=105264

Attachment 180107: Patch
https://bugs.webkit.org/attachment.cgi?id=180107&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
I was curious about includeMaxWidth, so I tracked this down to
http://trac.webkit.org/changeset/35828 .  It was added for the same reason
includeMinWidth is being added.

I think having 2 args is confusing.  Instead, we could have a single enum:
ComputePreferred, ComputeActual (default to ComputeActual).  In
computeReplacedLogicalWidthRespectingMinMaxWidth, if the enum is
ComputePreferred, we can ignore percent min or max widths.

Even with that change, I think RenderReplaced::computeMaxPreferredLogicalWidth
is still incorrect.  If the width is a percent but the min-width is greater
than the intrinsic logical width, the preferred size should be the min-width. 
I guess that's a separate bug.