[webkit-reviews] review denied: [Bug 65477] Nested fixed position element not staying with parent : [Attachment 179313] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix (vacations 20 dec -> 5 jan) <jchaffraix at webkit.org> has denied
Robert Hogan <robert at webkit.org>'s request for review:
Bug 65477: Nested fixed position element not staying with parent
https://bugs.webkit.org/show_bug.cgi?id=65477

Attachment 179313: Patch
https://bugs.webkit.org/attachment.cgi?id=179313&action=review

------- Additional Comments from Julien Chaffraix (vacations 20 dec -> 5 jan)
<jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179313&action=review


>> Source/WebCore/rendering/RenderBlock.cpp:302
>> +	    return;
> 
> Shouldn't this be a helper function? :)  RenderBlock*
nearestAncestorFixedPositionRoot()? or something?

Yes, it's called containingBlock() but we can't use it here as
ancestor->position() != FixedPosition. As discussed on IRC, this is a big red
flag to copy containingBlock and is a definite NO! for me as we have had tons
of bugs due to container() vs containingBlock() differences. This code is so
subtle that another copy is guaranteed to bite us down the road.