[webkit-reviews] review denied: [Bug 104664] [EFL [WebGL] [Wk2] Contents are not rendered properly. : [Attachment 180183] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Viatcheslav Ostapenko
<ostap73 at gmail.com>'s request for review:
Bug 104664: [EFL [WebGL] [Wk2] Contents are not rendered properly.
https://bugs.webkit.org/show_bug.cgi?id=104664

Attachment 180183: Patch
https://bugs.webkit.org/attachment.cgi?id=180183&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180183&action=review


There's no d

> Source/WebCore/ChangeLog:3
> +	   [EFL [WebGL] [Wk2] Contents are not rendered properly.

When, in what circumstances, and how does that get reproduced?

> Source/WebCore/ChangeLog:17
> +	   Covered by existing tests.

Which existing test, and how?

> Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:443
> +	   // Release previous lock and rebind texture to surface to get frame
update

. at end of sentence.

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp:45
>  void TextureMapperSurfaceBackingStore::swapBuffersIfNeeded(uint32_t
frontBuffer)
>  {
> -    if (m_graphicsSurface && m_graphicsSurface->frontBuffer() !=
frontBuffer)
> +    UNUSED_PARAM(frontBuffer);

The style guides say to use void
TextureMapperSurfaceBackingStore::swapBuffersIfNeeded(uint32_t), use
UNUSED_PARAM only in an #ifdef clause case.