[webkit-reviews] review requested: [Bug 105324] Use ElementTraversal in LiveNodeListBase : [Attachment 180186] patch3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 19 09:55:40 PST 2012
Antti Koivisto <koivisto at iki.fi> has asked for review:
Bug 105324: Use ElementTraversal in LiveNodeListBase
https://bugs.webkit.org/show_bug.cgi?id=105324
Attachment 180186: patch3
https://bugs.webkit.org/attachment.cgi?id=180186&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Some changes as discussed with Ryosuke
- removed isAcceptableElement(), always use isMatchingElement templates instead
- separated ChildNodeList iteration function. It is the only one that operates
on Nodes instead of Elements.
- bring back the accidentally removed ALWAYS_INLINEs for the backwards case
Also made it less buggy.
More information about the webkit-reviews
mailing list