[webkit-reviews] review granted: [Bug 105412] [EFL][WK2] Move deviceScaleFactor to our view as it's view related : [Attachment 180130] Patch

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.gombos at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 105412: [EFL][WK2] Move deviceScaleFactor to our view as it's view related
https://bugs.webkit.org/show_bug.cgi?id=105412

Attachment 180130: Patch
https://bugs.webkit.org/attachment.cgi?id=180130&action=review

------- Additional Comments from Laszlo Gombos <laszlo.gombos at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180130&action=review


Looks good to me but I would appreciate to address the comments below.

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:292
> +void EwkViewImpl::setDeviceScaleFactor(float scale)

Nit: Any reason not to use the same symbol name name as the implementation -
EwkViewImpl::setIntrinsicDeviceScaleFactor ?

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:302
> +    // Note that the scale factor incl page and device scale for now.

Nit: incl -> includes