[webkit-reviews] review granted: [Bug 103226] [JSC] Add support for overloaded constructors : [Attachment 179940] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 103226: [JSC] Add support for overloaded constructors
https://bugs.webkit.org/show_bug.cgi?id=103226

Attachment 179940: Patch
https://bugs.webkit.org/attachment.cgi?id=179940&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179940&action=review


This is a great improvement.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3774
> +	       next if exists $fetchedArguments{$parameterIndex};

Why can the same parameterIndex appear twice in @neededArguments ?

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3980
> +	       $numberOfConstructorParameters = 1024;

Nit: Let's use 255 as we're using 255 in other places.