[webkit-reviews] review granted: [Bug 105275] REGRESSION (r118044): CSSParser crashes, when no context is available, and the value is a valid keyword : [Attachment 180052] Proposed patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Renata Hodovan <reni at webkit.org>'s
request for review:
Bug 105275: REGRESSION (r118044): CSSParser crashes, when no context is
available, and the value is a valid keyword
https://bugs.webkit.org/show_bug.cgi?id=105275

Attachment 180052: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=180052&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180052&action=review


> LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt:1

> +Excellent - did not crash. See bug
https://bugs.webkit.org/show_bug.cgi?id=105275

Nit: Normally we write something like "This test passes if it does not crash."
or just PASS, but this is also OK.

> LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash.svg:10
> +	   testRunner.dumpAsText();

Please indent the dumpAsText() line 4 more spaces.