[webkit-reviews] review denied: [Bug 104600] [Chromium] Always enable autocomplete for password fields : [Attachment 178839] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Yue Zhang <zysxqn at chromium.org>'s
request for review:
Bug 104600: [Chromium] Always enable autocomplete for password fields
https://bugs.webkit.org/show_bug.cgi?id=104600

Attachment 178839: Patch
https://bugs.webkit.org/attachment.cgi?id=178839&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178839&action=review


ChangeLog needs work.

> Source/WebKit/chromium/ChangeLog:8
> +	   Additional information of the change such as approach, rationale.
Please add per-function descriptions below (OOPS!).

The OOPS will block the commit.  YOu're suppose to delete this line and replace
it with what it says to. :)

> Source/WebKit/chromium/ChangeLog:9
> +	   We should always save generated passwords regardless of the
autocomplete setting, since users have already given cresent to save the
passwords by choosing to use generated passwords. So in this change we disable
autocomplete checking in webkit and we will handle password autocomplete
setting in chromium code in another chromium CL.

I think you might want to wrap this for ease of reading. :)