[webkit-reviews] review requested: [Bug 61862] EventSource should support CORS : [Attachment 180024] patch 8

[bugzilla-daemon at webkit.org]

Per-Erik Brodin <per-erik.brodin at ericsson.com> has asked  for review:
Bug 61862: EventSource should support CORS
https://bugs.webkit.org/show_bug.cgi?id=61862

Attachment 180024: patch 8
https://bugs.webkit.org/attachment.cgi?id=180024&action=review

------- Additional Comments from Per-Erik Brodin <per-erik.brodin at ericsson.com>
(In reply to comment #46)
> >
LayoutTests/http/tests/eventsource/eventsource-cors-no-server-expected.txt:3
> > +FAIL: got error event but readyState is CONNECTING
> 
> Is this OK?
The failing test was originally for bug 70112 and my plan was to update the
expected result when fixing that one. However, the spec changed recently so the
current behavior is correct.
I have updated the test accordingly.

> 
> > Source/WebCore/page/EventSource.cpp:124
> > +	 options.allowCredentials = origin->canRequest(m_url) ||
m_withCredentials ? AllowStoredCredentials : DoNotAllowStoredCredentials;
> 
> I would put braces around the condition for clarity (and because this makes
it look more like an if () condition).

Fixed.