[webkit-reviews] review canceled: [Bug 100754] Faster sorting of numeric arrays : [Attachment 179542] Patch and tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 18 12:42:42 PST 2012
Cosmin Truta <ctruta at gmail.com> has canceled Cosmin Truta <ctruta at gmail.com>'s
request for review:
Bug 100754: Faster sorting of numeric arrays
https://bugs.webkit.org/show_bug.cgi?id=100754
Attachment 179542: Patch and tests
https://bugs.webkit.org/attachment.cgi?id=179542&action=review
------- Additional Comments from Cosmin Truta <ctruta at gmail.com>
Inclusion of "UnlinkedCodeBlock.h" added a declaration of JSC::Node in WebKit2,
which clashed with WebCore::Node and broke the build on EFL and Windows. Not
sure why the build broke on Mac and Qt, though. (Could it be because of
indirect inclusion of the parser?)
I fixed it by qualifying WebCore::Node explicitly in WebKit2, and tested it on
the EFL build. Let's hope it passes on the other platforms also.
More information about the webkit-reviews
mailing list