[webkit-reviews] review denied: [Bug 105319] [GStreamer] Buffering ranges are reported incorrectly with GStreamer 1.0 : [Attachment 179971] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 18 10:03:09 PST 2012
Philippe Normand <pnormand at igalia.com> has denied Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 105319: [GStreamer] Buffering ranges are reported incorrectly with
GStreamer 1.0
https://bugs.webkit.org/show_bug.cgi?id=105319
Attachment 179971: Patch
https://bugs.webkit.org/attachment.cgi?id=179971&action=review
------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=179971&action=review
>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:749
> +#if !defined(GST_API_VERSION_1) && GST_CHECK_VERSION(0, 10, 31)
This code should work for both gst 1.0 and 0.10. If there's a bug when gst 1.0
is enabled it should be fixed :)
More information about the webkit-reviews
mailing list