[webkit-reviews] review granted: [Bug 104168] Web Inspector: Add events for tracking when a page is about to start loading or is loading : [Attachment 179959] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 18 09:38:46 PST 2012
Pavel Feldman <pfeldman at chromium.org> has granted Ken Kania
<kkania at chromium.org>'s request for review:
Bug 104168: Web Inspector: Add events for tracking when a page is about to
start loading or is loading
https://bugs.webkit.org/show_bug.cgi?id=104168
Attachment 179959: Patch
https://bugs.webkit.org/attachment.cgi?id=179959&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179959&action=review
Please fix the naming prior to landing.
> Source/WebCore/inspector/Inspector.json:494
> + { "name": "frame", "$ref": "Network.FrameId",
"description": "Id of the frame that has started loading." }
You should name it frameId
More information about the webkit-reviews
mailing list