[webkit-reviews] review granted: [Bug 104419] [CSS Exclusions] shape-inside layout fails to adjust first line correctly for writing-mode: vertical-rl : [Attachment 179830] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 104419: [CSS Exclusions] shape-inside layout fails to adjust first line
correctly for writing-mode: vertical-rl
https://bugs.webkit.org/show_bug.cgi?id=104419

Attachment 179830: Patch
https://bugs.webkit.org/attachment.cgi?id=179830&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179830&action=review


LGTM. Just a snippet. R=me

> Source/WebCore/rendering/ExclusionShape.cpp:145
> +	   exclusionShape->m_boundingBox = FloatRect(logicalCenter -
logicalRadii, logicalRadii + logicalRadii);

2 * radii