[webkit-reviews] review denied: [Bug 104168] Web Inspector: Add events for tracking when a page is about to start loading or is loading : [Attachment 179527] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 18 05:22:10 PST 2012


Pavel Feldman <pfeldman at chromium.org> has denied Ken Kania
<kkania at chromium.org>'s request for review:
Bug 104168: Web Inspector: Add events for tracking when a page is about to
start loading or is loading
https://bugs.webkit.org/show_bug.cgi?id=104168

Attachment 179527: Patch
https://bugs.webkit.org/attachment.cgi?id=179527&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179527&action=review


> Source/WebCore/inspector/Inspector.json:494
> +		       { "name": "frame", "$ref": "Frame", "description":
"Frame object." }

Originally, we were only sending the frame information once in frameNavigated
and then operated frameId only. Is there a predefined order of appearance of
frameNavigated / frameStartedLoading / frameScheduledNavigation? It would be
great if we could send frame with the first one and operate frameId with the
latter.


More information about the webkit-reviews mailing list