[webkit-reviews] review granted: [Bug 105162] Web Inspector: MediaQueryList listener silently catches errors : [Attachment 179908] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 105162: Web Inspector: MediaQueryList listener silently catches errors
https://bugs.webkit.org/show_bug.cgi?id=105162

Attachment 179908: Patch
https://bugs.webkit.org/attachment.cgi?id=179908&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179908&action=review


Please address the comments prior to landing.

> LayoutTests/http/tests/inspector-protocol/resources/protocol-test.js:67
> +	   return;

The common behavior in this situation is to output something like "This test
requires DumpRenderTree", since oftentimes tests can be run manually in the
browser.

> LayoutTests/inspector-protocol/media-query-listener-exception-expected.txt:3
> +Test that uncaught exception in MediaQueryListListener will be reported to
the console. On success you should see to exceptions in the listener logged to
the console(first time when the device metrics are overriden and second - when
they are restored). Bug 105162.

"to exceptions" -> "two exceptions"
space before '('
"device metrics are" -> "media type is"
"overriden" -> "overridden"