[webkit-reviews] review denied: [Bug 105168] Web Inspector: refactor DefaultTextEditor's |expanded| setters : [Attachment 179730] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 105168: Web Inspector: refactor DefaultTextEditor's |expanded| setters
https://bugs.webkit.org/show_bug.cgi?id=105168

Attachment 179730: Patch
https://bugs.webkit.org/attachment.cgi?id=179730&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179730&action=review


It's not clear what is the main purpose of this patch.

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:818
> +	   this._repaintAll();

Why did you add it here?

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:936
> +	       return false;

Why do you need this return value?

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1370
> +	       return false;

Why do you need to return false here and why don't you return true in the end?