[webkit-reviews] review granted: [Bug 105242] [Shadow] LargeDistributionWithLayout.html should be updated : [Attachment 179875] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 17 21:39:10 PST 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 105242: [Shadow] LargeDistributionWithLayout.html should be updated
https://bugs.webkit.org/show_bug.cgi?id=105242

Attachment 179875: Patch
https://bugs.webkit.org/attachment.cgi?id=179875&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179875&action=review


> PerformanceTests/ShadowDOM/LargeDistributionWithLayout.html:26
> +    window.content = document.createElement('content');

Why don't we just declare this variable outside of the function? So this test
wasn't doing anything useful before?

> PerformanceTests/ShadowDOM/LargeDistributionWithLayout.html:27
> +    window.shadowRoot = host.webkitCreateShadowRoot();

I don't think we need to expose this variable. It's not used elsewhere.


More information about the webkit-reviews mailing list