[webkit-reviews] review granted: [Bug 105213] REGRESSION(r136324): flex items with percent heights not resizing : [Attachment 179794] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 17 20:47:23 PST 2012


Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 105213: REGRESSION(r136324): flex items with percent heights not resizing
https://bugs.webkit.org/show_bug.cgi?id=105213

Attachment 179794: Patch
https://bugs.webkit.org/attachment.cgi?id=179794&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179794&action=review


Up to you on the naming. Figured I'd at least try to make a suggestion. :)

> Source/WebCore/rendering/RenderBlock.h:531
> +    void
updateNeedsLayoutAndPreferredLogicalWidthsDirtyBeforeBlockChildLayout(bool
relayoutChildren, RenderBox* child);

Ugh. This is so verbose. I can't think of anything more concise though.
updateDirtyBitsBeforeBlockChildLayout?


More information about the webkit-reviews mailing list