[webkit-reviews] review granted: [Bug 105246] REGRESSION(r137442): Crash because of an uninitialized member. : [Attachment 179869] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 17 20:31:57 PST 2012
Noam Rosenthal <noam at webkit.org> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 105246: REGRESSION(r137442): Crash because of an uninitialized member.
https://bugs.webkit.org/show_bug.cgi?id=105246
Attachment 179869: Patch
https://bugs.webkit.org/attachment.cgi?id=179869&action=review
------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179869&action=review
> Source/WebCore/ChangeLog:10
> + TextureMapperGL defines m_context although TextureMapper defines
m_context. It
> + is why r137442 made a mistake to remove initialization code of
m_context in
> + TextureMapperGL. This patch removes the duplicated member in
TextureMapperGL.
It is why r137442 made a mistake to remove initialization code of m_context in
TextureMapperGL
-> r137442 removes the initialization code in TextureMapperGL, which is what
causes this regression.
More information about the webkit-reviews
mailing list